Menu

📰
0

What’s the general etiquette for PRs?

Reddit r/cscareerquestions·u/airpAth0929·about 1 month ago
#3KQSvh9A
Reading 0:00
15s threshold

Whenever I make a PR and ask my team on slack to ask reviews, I usually get nothing. I’ve resorted to hunting down a few members who’re likely to respond quickly for reviews so I can get them approved and merged.

Sometimes they request changes, which I get done pretty quickly, and let them know the PR has been updated and is ready for review. If they don’t respond within a couple hours, is it impolite to @ them again?

Read More